Skip to content

Refactor Badges#310

Merged
teutoburg merged 5 commits intodev_masterfrom
fh/badges2
Feb 6, 2026
Merged

Refactor Badges#310
teutoburg merged 5 commits intodev_masterfrom
fh/badges2

Conversation

@teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Feb 5, 2026

  • Use Badges from astar-utils
  • Delete double implementation of Badges
  • Run internal functionality tests (unrelated to any specific instrument package) separately

This was pulled from a 6 months old branch...

Those don't need to run in the full test matrix.
This has been moved to astar-utils for the longest time, but never actually
update the code to use that...
@teutoburg teutoburg self-assigned this Feb 5, 2026
@teutoburg teutoburg added the irdb functionality Publish script, packaging, badges etc. label Feb 5, 2026
@teutoburg teutoburg moved this to 🏗 In progress in ScopeSim-development Feb 5, 2026
@teutoburg teutoburg changed the title Fh/badges2 Refactor Badges Feb 5, 2026
@teutoburg teutoburg marked this pull request as ready for review February 5, 2026 14:40
@teutoburg
Copy link
Contributor Author

Separate tests are correctly triggered by label: https://github.com/AstarVienna/irdb/actions/runs/21715756177/job/62631118699?pr=310

@teutoburg teutoburg moved this from 🏗 In progress to 👀 Awaiting Review in ScopeSim-development Feb 5, 2026
@teutoburg teutoburg requested a review from a team February 5, 2026 14:44
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume that some of this functionality has been moved to astar utils.

Either way, good to keep this a bit up to date.

@teutoburg
Copy link
Contributor Author

I'm going to assume that some of this functionality has been moved to astar utils.

Indeed, a while ago, but I never finished the job here...

@teutoburg teutoburg merged commit 3f281f3 into dev_master Feb 6, 2026
37 checks passed
@github-project-automation github-project-automation bot moved this from 👀 Awaiting Review to ✅ Done in ScopeSim-development Feb 6, 2026
@teutoburg teutoburg deleted the fh/badges2 branch February 6, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

irdb functionality Publish script, packaging, badges etc.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants